Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stockholm transfer #169

Draft
wants to merge 148 commits into
base: current_stockholm_master
Choose a base branch
from

Conversation

Jakob37
Copy link

@Jakob37 Jakob37 commented Nov 15, 2024

This PR adds a functionality or fixes a bug.
OR
This PR marks a new Gens release. We apply semantic versioning. This is a major/minor/patch release for reasons.

How to test:

  1. how to test it, possibly with real cases/data

Expected outcome:
The functionality should be working
Take a screenshot and attach or copy/paste the output.

Review:

  • code approved by

Discussion points

  • How to deal with the .github workflows set up by Stockholm? (Working with their instance)
  • Addition of case_id. What consequences? I suspect we will need to migrate our Gens db before merge.
  • Updates to preprocessing scripts generate_gens_data.pl and gvcfvaf.pl. Needs to be tested separately? We are using a different script in the ol' wgs repo?
  • Individual ID used in addition to the sample_id and case_id. What is the significance?
  • Leaving out for now as it is not completed: Start something that would Fix #32 Clinical-Genomics/gens#92
  • The changelog is a mess. Let's see how to organize it.
  • Looks like Gens is merging with Scout through its database. Let's think about how we want to approach that.

Migration steps

  • Update the case_id. Here for a single test sample: db.samples.updateOne({}, {"$set": {"case_id": "hg002"}})
  • Login screen. Make sure it works OK. Seems to look for user email in the Scout db, which should work good enough for now. Do we want to use the same LDAP system as in Scout eventually?

mhkc and others added 30 commits February 6, 2024 14:21
…x-arg-is-an-empty-sequence-error-when-searching-for-gpr101

Fixed max args error when searching for genes
…ens-using-links-from-scout' of github.com:Clinical-Genomics-Lund/gens into 133-sometimes-the-wrong-variant-is-being-displayed-in-gens-using-links-from-scout
…-wrong-variant-is-being-displayed-in-gens-using-links-from-scout

Fix caching to prevent displaying the wrong variant
…-annotation-tracks

Fixed bug that prevented updating annotation tracks
@Jakob37 Jakob37 changed the title Stockholm transfer (round 2: getting their commits) Stockholm transfer Nov 19, 2024
@Jakob37 Jakob37 changed the base branch from master to current_stockholm_master November 19, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants